Skip to content

Add .pypirc specification#734

Merged
theacodes merged 4 commits into
pypa:masterfrom
bhrutledge:730-pypirc
Jun 5, 2020
Merged

Add .pypirc specification#734
theacodes merged 4 commits into
pypa:masterfrom
bhrutledge:730-pypirc

Conversation

@bhrutledge

Copy link
Copy Markdown
Contributor

Closes #730.

I'm starting this out as a draft PR, because I think a complete PR would include updates to other documents that reference .pypirc. However, before spending time on that, I'd like get the content of this document approved.

Comment thread source/specifications/pypirc.rst Outdated
@stdedos

stdedos commented May 30, 2020

Copy link
Copy Markdown

LGTM from user's perspective.

Also clears up how the "don't save your token in plaintext" wizardry works

@bhrutledge

Copy link
Copy Markdown
Contributor Author

To see the rendered version without building locally, check out:

https://bhrutledge-ppug.bhrutledge.now.sh/specifications/pypirc.html

Comment thread source/specifications/pypirc.rst
@stdedos

stdedos commented May 30, 2020

Copy link
Copy Markdown

Thank you for the extra mile!

Also in-line rendering looks good enough to get rendered text display
image

Comment thread source/specifications/pypirc.rst
@bhrutledge

bhrutledge commented Jun 2, 2020

Copy link
Copy Markdown
Contributor Author

@di I hope you'll forgive the nudge, but I'd appreciate your thoughts on this before I link to it from other parts of the guide. And, ultimately, it'd be nice to resolve pypa/twine#638.

@di

di commented Jun 2, 2020

Copy link
Copy Markdown
Member

@bhrutledge On my list for today.

Comment thread source/specifications/pypirc.rst
Comment thread source/specifications/pypirc.rst Outdated
Comment thread source/specifications/pypirc.rst Outdated
Comment thread source/specifications/pypirc.rst Outdated
Comment thread source/specifications/pypirc.rst Outdated
Comment thread source/specifications/pypirc.rst Outdated
Comment thread source/specifications/pypirc.rst Outdated
@bhrutledge bhrutledge marked this pull request as ready for review June 4, 2020 12:12
@bhrutledge bhrutledge requested a review from di June 4, 2020 12:12

@di di left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, only one suggestion & a reiteration of a previous comment.

Comment thread source/specifications/pypirc.rst Outdated
Comment thread source/specifications/pypirc.rst Outdated
@merwok

merwok commented Jun 4, 2020

Copy link
Copy Markdown
Contributor

For reference, here is the distutils documentation about .pypirc before it was deleted from the CPython repo: https://github.com/python/cpython/blob/v3.4.10/Doc/distutils/packageindex.rst#the-pypirc-file

@bhrutledge

Copy link
Copy Markdown
Contributor Author

For reference, here is the distutils documentation about .pypirc before it was deleted from the CPython repo

Thanks! I actually started with that, then updated/expanded it.

@bhrutledge bhrutledge requested a review from di June 5, 2020 10:25

@di di left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@di

di commented Jun 5, 2020

Copy link
Copy Markdown
Member

Any other @pypa/packaging-user-guide-editors want to review?

@theacodes theacodes merged commit 86c0641 into pypa:master Jun 5, 2020
@bhrutledge bhrutledge deleted the 730-pypirc branch June 8, 2020 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing documention for .pypirc format

5 participants